chore: Add envvars to override writer configs and cometConf minor clean up#3540
Merged
Conversation
andygrove
reviewed
Feb 17, 2026
| .stringConf | ||
| .createOptional | ||
|
|
||
| val COMET_MAX_TEMP_DIRECTORY_SIZE: ConfigEntry[Long] = |
Member
There was a problem hiding this comment.
Some of these configs are used directly from native code. We add them here so that they get documented.
Member
There was a problem hiding this comment.
in spark_config.rs:
pub(crate) const COMET_TRACING_ENABLED: &str = "spark.comet.tracing.enabled";
pub(crate) const COMET_DEBUG_ENABLED: &str = "spark.comet.debug.enabled";
pub(crate) const COMET_EXPLAIN_NATIVE_ENABLED: &str = "spark.comet.explain.native.enabled";
pub(crate) const COMET_MAX_TEMP_DIRECTORY_SIZE: &str = "spark.comet.maxTempDirectorySize";
pub(crate) const COMET_DEBUG_MEMORY: &str = "spark.comet.debug.memory";
Contributor
Author
There was a problem hiding this comment.
Ic, I'll add comments!
comphead
changed the title
andygrove
reviewed
Feb 18, 2026
Comment on lines
-798
to
-804
| val COMET_REGEXP_ALLOW_INCOMPATIBLE: ConfigEntry[Boolean] = | ||
| conf("spark.comet.regexp.allowIncompatible") | ||
| .category(CATEGORY_EXEC) | ||
| .doc("Comet is not currently fully compatible with Spark for all regular expressions. " + | ||
| s"Set this config to true to allow them anyway. $COMPAT_GUIDE.") | ||
| .booleanConf | ||
| .createWithDefault(false) |
Member
There was a problem hiding this comment.
Removing the config here will remove it from the configuration guide, but maybe that is fine, so long as we are explaining it in the compatibility guide.
andygrove
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
regexpto be in sync with other incompatsWhat changes are included in this PR?
How are these changes tested?